remove most imports from builtins (range, str, object, map)#31
Open
fchapoton wants to merge 1 commit intofredstro:developfrom
Open
remove most imports from builtins (range, str, object, map)#31fchapoton wants to merge 1 commit intofredstro:developfrom
fchapoton wants to merge 1 commit intofredstro:developfrom
Conversation
Author
|
Note that I have no way to run the doctests, as I am not able to install psage.. |
Owner
|
That's alright. I run all doctests before merging. Unfortunately there are currently a lot of failing doctests, most likely due to a new ordering of ideal generators in Sage (I think it is somewhere in the hermite normal form code) and I am trying to verify and update as many of those tests as I can... |
Author
|
I have now (in my fork) started a large-scale clean-up and update of the full codebase. I may have broken things in doing so. Could you please tell me in what folders I should expect all doctests to pass ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as they have no effect when using python3